Ticket #952 (closed defect: fixed)

Opened 1 year ago

Last modified 3 months ago

Empty list of plugins/services with 1.4.5

Reported by: blueyed Assigned to: nobody
Priority: high Milestone: Munin 1.4.6
Component: node Version: 1.4.5
Severity: normal Keywords:
Cc:

Description

I've upgraded my munin-node instance on my OpenVZ hardware node to 1.4.5-1 from Debian testing, but this caused the list of services to be empty (via "telnet localhost 4949", then "list").

Downgrading to 1.4.4-1~blueyedppa2 (basically a backport of 1.4.4-1 from Debian).

There are plugins installed (quite a lot), and I can run them manually using munin-run.

Change History

08/19/10 00:16:57 changed by blueyed

btw: I've looked at the points listed in http://munin-monitoring.org/wiki/FAQ_no_graphs (after having seen a link to it in some log file).

08/20/10 18:56:44 changed by ligne

thanks for the report.

if you try launching munin-node with the --debug option enabled, you should find that munin-node.log lists all the plugins that are being loaded, and also report any plugins that are being dropped due to errors.

09/03/10 19:23:43 changed by 20

I can confirm that after the package was updated from 1.4.3 to 1.4.5 on RHEL5 (using the epel repository) that munin stopped listing the plugins, however fetch appears to be working normally:

Before upgrade:

$ telnet localhost 4949
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
# munin node at ###########.com
list
apache_accesses apache_processes apache_volume cpu df df_inode entropy forks fw_packets http_loadtime if_err_eth0 if_err_eth1 if_eth0 if_eth1 interrupts iostat iostat_ios irqstats load memory munin_stats netstat nfs4_client ntp_kernel_err ntp_kernel_pll_freq ntp_kernel_pll_off ntp_offset open_files open_inodes postfix_mailqueue postfix_mailvolume proc_pri processes sendmail_mailqueue sendmail_mailstats sendmail_mailtraffic swap threads uptime users vmstat yum

After:

$ telnet localhost 4949
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
# munin node at ###########.com
list

09/04/10 00:08:05 changed by 20

The problem appears to be (for me) that in node/lib/Munin/Node/Server.pm:

!#perl
sub _list_services {
...
if (exists $nodes{$node})
...

exists $nodes{$node} evaluates to false. returning a faked array within an else statement:

!#perl
...
    } else {
        _net_write($session, join(" ", ('cpu','df_inode')));
...

confirms it.

As far as i can tell, the $node variable's value (used when storing and fetching the array of services) is identical... so what else could this be?

09/04/10 00:33:41 changed by 20

ok, this is a stupid fix, but it works for a single node:

!#perl
sub _list_services {
    my ($session, $node) = @_;
    $node ||= $config->{fqdn};

    logger(qq{Using node: $node});

    if (exists $nodes{$node}) {
        my @services = @{$nodes{$node}};

        # remove any plugins that require capabilities the master doesn't support
        @services = Munin::Node::Utils::set_difference(\@services, \@multigraph_services)
            unless $session->{server_capabilities}{multigraph};
        @services = Munin::Node::Utils::set_difference(\@services, \@dirtyconfig_services)
            unless $session->{server_capabilities}{dirtyconfig};

        _net_write($session, join(" ", @services));
    } else {
        my @services = keys %services;
        _net_write($session, join(" ", @services));
    }
    _net_write($session, "\n");
}

09/06/10 06:47:58 changed by 20

Solved in Server.pm:

312c312
<     $node ||= lc($config->{fqdn});
---
>     $node ||= $config->{fqdn};

The server name is forced to lowercase when the services are being set, but not when matching within sub _list_services. Please fix for next release.

09/14/10 20:51:06 changed by ligne

it looks like this was fixed in r3404, which unfortunately predates munin-1.4.5. but it should find it's way into the next release.

09/14/10 20:53:27 changed by ligne

specifically, it's this hunk here: http://munin-monitoring.org/changeset/3404#file19

01/07/11 12:11:34 changed by jo

  • status changed from new to closed.
  • resolution set to fixed.

Closing this ticket as ligne has backported the patch. The fix will be in the next 1.4 release.

10/27/11 11:49:58 changed by coalettplugat1986

Anyone who loves motion pictures is more likely to love movie downloads, too. The fact is this trend is changing into a big one and it's nice for those who want to create giant collections with out having to dole out high greenback or premium house area to do so. How to download video from vimeo at the moment are available legally from all kinds of huge movie studios and even television networks, as well. A video collection created digitally has an a variety of benefits over regular disk purchases, too. The largest perks of video downloads involve the storage points and pricing. But, why? Video downloads are usually just a few dollars or more lower than an everyday DVD purchase as a result of there is no such thing as a packaging points to contend with. Plus, there's the straightforward truth delivery is not an issue either. For the reason that firms that sell downloads save on transport and the movie studios save on packaging, they'll move on some of these savings on to buyers. In regard to storage, it is a simple reality of space. It's an entire lot simpler to retailer movies on a pc drive or a backup drive than it's to carry 100 videos in a room. There isn't any need for shelf after shelf or tons of DVD towers when a group is created through video download. Administration of movies and tv downloads generally is a entire lot easier, too. It is fairly simple to create folders on the computer to retailer motion pictures by style and it's a complete lot faster, too. Video downloads have gotten the favorites of many for a cause past storage or pricing. This reason is variety. The very fact is the kinds of downloads out there might be actually mind boggling. Let's look at what kinds of video downloads will be found legally: Hit motion pictures Just about every new film that hits the theaters will find yourself in a authorized download format shortly after release. This implies there's no have to run to the video store, or worse, pay prime dollar at a theater to see a new release. Television packages Vimeo video downloads Because the film studios jump on the bandwagon, so too are the tv studios. Hit shows from all many years might be found by the season or by the episode via video download.Classics Because the film download business becomes extra widespread, many studios are video by their catalogues and providing downloads of their older movies. From the classics of the 1920s to holiday favorites of the Eighties, they can all be discovered by way of video download. And, if a title cannot be found right now, it is possible it is going to be added soon as each major movie studio falls into place offering downloads by way of a lot of totally different sites. Video downloads present their customers with an on demand facet, worth financial savings and storage issue discount that common DVD buys cannot. As this new format becomes more and more accepted, it is changing into the method of selection for buying and watching movies. Authentic works There are tons of locations to get video downloads from newbie or little known creators. These movies might not have the monetary backing of a number of the major films in historical past, but that doesn't imply there is not some good leisure out there. Indie works are getting a whole new audience because of video downloads and the Internet.