Ticket #838 (reopened defect)

Opened 2 years ago

Last modified 2 years ago

munin-graph does not handle "any" length legend labels

Reported by: nitrox Assigned to: janl
Priority: normal Milestone:
Component: plugins Version: 1.4.3
Severity: minor Keywords:
Cc:

Description

Graphs are not aligned anymore as diskstats graphs are larger than the rest.

If you comment all "grpah_width 450" its using "sane" sizes and all is fine again, the hardcoded part produces larger graphs even when not needed.

thx, nitrox

Attachments

diskstats_iops-day.png (25.8 kB) - added by feiner.tom on 01/09/10 18:40:29.
diskstats graph from munin 1.4.3, resulting in a larger graph, 547x340 pixels
apache_volume-day.png (17.6 kB) - added by feiner.tom on 01/09/10 18:50:07.
apache_volume graph, resulting in the normal resolution: 497x280 pixels

Change History

01/09/10 18:40:29 changed by feiner.tom

  • attachment diskstats_iops-day.png added.

diskstats graph from munin 1.4.3, resulting in a larger graph, 547x340 pixels

01/09/10 18:50:07 changed by feiner.tom

  • attachment apache_volume-day.png added.

apache_volume graph, resulting in the normal resolution: 497x280 pixels

01/10/10 17:43:28 changed by robe

This was done on purpose because somewhat longer LVM volume names would cause line wraps which result in unreadable stat values.

Is there a policy on Munin's side how shipped plugins should behave?

I can easily turn this into a configurable setting or make it "heuristic", if need be. Suggestions are welcome

01/11/10 22:33:28 changed by janl

I'm afraid Munin simply does not have any way to handle too long label names well. A patch to munin-graph would be appreciated O:-) As it is I'll leave this to robe's judgement - until I covardly give in to a large discussion on the users list.

Nicolai

01/15/10 19:17:15 changed by robe

https://workbench.amd.co.at/hg/munin-plugins/raw-file/d0b3d0baa2db/diskstats handles this a bit better. By default the plugin increases graph_width as needed (starting from 400). If you enable label trimming the graph_width stays the same but the labels are trimmed as needed.

No implementation in munin core because I didn't want to delve so deep into rrd country and the whole typeface area.

This version also closes #835 and #837.

01/18/10 12:53:52 changed by janl

  • owner changed from nobody to janl.
  • status changed from new to assigned.
  • summary changed from diskstats (the new) plugin - graph_with 450 hardcoded to munin-graph does not handle "any" length legend labels.

02/26/10 16:44:38 changed by feiner.tom

  • status changed from assigned to closed.
  • resolution set to fixed.

02/27/10 21:40:31 changed by janl

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone deleted.

This needs to be fixed in general in munin-graph too. Reopening ticket and removing the milestone. Not sure when we can fix this.