Changeset 3883

Show
Ignore:
Timestamp:
09/02/10 20:12:53 (1 year ago)
Author:
bldewolf
Message:

Clean up Perl warnings due to use of undefined variables in two functions in LimitsOld?.pm in 1.4-stable as well.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • branches/1.4-stable/master/lib/Munin/Master/LimitsOld.pm

    r3400 r3883  
    481481        $critical[0] = $1 if length $1; 
    482482        $critical[1] = $2 if length $2; 
    483         DEBUG "[DEBUG] processing critical: $name -> $critical[0] : $critical[1]"; 
    484483    } 
    485484    elsif (defined $crit and $crit =~ /^\s*([-+\d.]+)\s*$/) { 
    486         $critical[1] = $1 if defined $1; 
    487         DEBUG "[DEBUG] processing critical: $name -> : $critical[1]"; 
     485        $critical[1] = $1; 
    488486    } 
    489487    elsif (defined $crit) { 
    490488        @critical = (0, 0); 
    491         DEBUG "[DEBUG] processing critical: $name -> $critical[0] : $critical[1]"; 
    492     } 
     489    } 
     490    if(defined $crit) { 
     491        DEBUG "[DEBUG] processing critical: $name -> " 
     492                . (defined $critical[0]? $critical[0] : "") 
     493                .  " : " 
     494                . (defined $critical[1]? $critical[1] : ""); 
     495    }    
    493496 
    494497    if (defined $warn and $warn =~ /^\s*([-+\d.]*):([-+\d.]*)\s*$/) { 
    495498        $warning[0] = $1 if length $1; 
    496499        $warning[1] = $2 if length $2; 
    497         DEBUG "[DEBUG] processing warning: $name -> $warning[0] : $warning[1]"; 
    498500    } 
    499501    elsif (defined $warn and $warn =~ /^\s*([-+\d.]+)\s*$/) { 
    500         $warning[1] = $1 if defined $1; 
    501         DEBUG "[DEBUG] processing warning: $name -> : $warning[1]"; 
     502        $warning[1] = $1; 
    502503    } 
    503504    elsif (defined $warn) { 
    504505        @warning = (0, 0); 
    505         DEBUG "[DEBUG] processing warning: $name -> $warning[0] : $warning[1]"; 
     506    } 
     507    if(defined $warn) { 
     508        DEBUG "[DEBUG] processing warning: $name -> " 
     509                . (defined $warning[0]? $warning[0] : "") 
     510                .  " : " 
     511                . (defined $warning[1]? $warning[1] : ""); 
    506512    } 
    507513 
     
    713719 
    714720 
    715     while (length($text)) { 
     721    while (defined($text) && length($text)) { 
    716722        if ($text =~ /^([^\$]+|)(?:\$(\{.*)|)$/) { 
    717723            push @res, $1; 
    718724            $text = $2; 
    719725        } 
     726 
    720727        my @a = extract_bracketed($text, '{}'); 
     728        if(!defined $a[0]) { 
     729            $text = $a[1]; 
     730            next; 
     731        } 
     732 
    721733        if ($a[0] =~ /^\{var:(\S+)\}$/) { 
    722734            $a[0] = munin_get($hash, $1, "");